On Sun, 20 Mar 2022 23:10:31 +0100 Petr Štetiar ynezz@true.cz wrote:
Hi Petr,
Andre Przywara andre.przywara@arm.com [2022-02-01 01:41:12]:
Since we have an SPL, which is called right after s_init(), move those calls to our board_init_f() function. As we overwrite this only for the SPL, this has the added benefit of not doing this setup *again* shortly afterwards, when running U-Boot proper.
something didn't went as expected, since this commit has broken ethernet on my A20-OLinuXino-LIME2:
Thanks for the report, much appreciated! And yes, there is a regression, I figured this myself already the other week. I sent https://lore.kernel.org/u-boot/20220316005443.16260-1-andre.przywara@arm.com...
Can you check whether this fixes it for you? Then reply with a Tested-by:? I will then send the PR in the next days, so that 2022.04 should be fine.
Thanks! Andre
U-Boot SPL 2022.04-rc4-00052-g2a243d9bd62f (Mar 20 2022 - 22:57:07 +0100) DRAM: 1024 MiB CPU: 912000000Hz, AXI/AHB/APB: 3/2/2 Trying to boot from FEL
U-Boot 2022.04-rc4-00052-g2a243d9bd62f (Mar 20 2022 - 22:57:07 +0100) Allwinner Technology
CPU: Allwinner A20 (SUN7I) Model: Olimex A20-OLinuXino-LIME2-eMMC DRAM: 1 GiB Core: 38 devices, 19 uclasses, devicetree: separate WDT: Not starting watchdog@1c20c90 MMC: mmc@1c0f000: 0, mmc@1c11000: 1 Loading Environment from FAT... Unable to read "uboot.env" from mmc0:1... Unknown monitor Unknown monitor In: serial Out: serial Err: serial Allwinner mUSB OTG (Peripheral) Net: Could not get PHY for ethernet@1c50000: addr 1
Reverting this commit fixes it:
Net: eth0: ethernet@1c50000, eth1: usb_ether
Cheers,
Petr