Hi Eugen,
On 2024/3/5 13:40, Eugen Hristev wrote:
On 3/5/24 04:10, Trevor Woerner wrote:
Following the pattern of other Rockchip devices, enable the U-Boot environment to be stored in MMC. This patch specifically assumes the environment will be stored on the SDcard.
Signed-off-by: Trevor Woernertwoerner@gmail.com
configs/rock5a-rk3588s_defconfig | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/configs/rock5a-rk3588s_defconfig b/configs/rock5a-rk3588s_defconfig index a6471a519514..ac6411667d9a 100644 --- a/configs/rock5a-rk3588s_defconfig +++ b/configs/rock5a-rk3588s_defconfig @@ -8,6 +8,7 @@ CONFIG_SPL_LIBGENERIC_SUPPORT=y CONFIG_NR_DRAM_BANKS=2 CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xc00000 +CONFIG_ENV_SIZE=0x8000 CONFIG_DEFAULT_DEVICE_TREE="rk3588s-rock-5a" CONFIG_ROCKCHIP_RK3588=y CONFIG_SPL_ROCKCHIP_COMMON_BOARD=y @@ -48,6 +49,8 @@ CONFIG_CMD_REGULATOR=y CONFIG_SPL_OF_CONTROL=y CONFIG_OF_LIVE=y CONFIG_OF_SPL_REMOVE_PROPS="clock-names interrupt-parent assigned-clocks assigned-clock-rates assigned-clock-parents" +CONFIG_ENV_IS_IN_MMC=y +CONFIG_SYS_MMC_ENV_DEV=1 CONFIG_SPL_DM_SEQ_ALIAS=y CONFIG_SPL_REGMAP=y CONFIG_SPL_SYSCON=y
Hi Trevor,
What will happen if there is no Sd-Card, and we boot from eMMC or SPI flash ?
The U-Boot should boot correctly with default env, and without any env from storage.
The env is used for U-Boot preoper, they should come from the same storage.
The rockchip pattern is usually to have a standard config for all boards and it is not stored anywhere.
Do you mean rockchip vendor U-Boot? I think rockchip vendor U-Boot does not depends on the env on storage,
it use default env for boot process and a vendor defined "vendor storage" for MAC/SN.
Thanks,
- Kever
Kever, Jonas, please correct me if I am wrong.
Eugen