Re: [U-Boot-Users] [PATCH] cfi_flash: Fix bug in flash_isset() to use correct 32bit function

In message 1199279186-9871-1-git-send-email-sr@denx.de you wrote:

This bug was detected on the LWMON5 target which has 2 Intel 16bit wide flash chips connected to a 32bit wide port.

Signed-off-by: Stefan Roese sr@denx.de

drivers/mtd/cfi_flash.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c index d1124d3..4f61e36 100644 --- a/drivers/mtd/cfi_flash.c +++ b/drivers/mtd/cfi_flash.c @@ -527,7 +527,7 @@ static int flash_isset (flash_info_t * info, flash_sect_t sect, retval = ((flash_read16(addr) & cword.w) == cword.w); break; case FLASH_CFI_32BIT:

• retval = ((flash_read16(addr) & cword.l) == cword.l);
  

• retval = ((flash_read32(addr) & cword.l) == cword.l);
  

  break; case FLASH_CFI_64BIT: retval = ((flash_read64(addr) & cword.ll) == cword.ll);

Checked in, thanks.

Best regards,

Wolfgang Denk