Hi
On Wed, Jul 20, 2022 at 9:56 AM Michael Nazzareno Trimarchi michael@amarulasolutions.com wrote:
Hi
On Wed, Jul 20, 2022 at 9:40 AM Tudor.Ambarus@microchip.com wrote:
On 7/19/22 13:46, Balamanikandan Gunasundar wrote:
This patch series adds support for NAND flash. The series adds DM support and replaces the existing NAND driver NAND_ATMEL. The drivers are ported from Linux based on the work done by Boris brezillon
If you're going to resubmit, it would be helpful to specify on top of which kernel version your work is based on. This would help to backport fixes or new support in the future.
Please in commit message mention what was changed/dropped for example:
- force poll instead of interrupt
- move platform_device to udevice
- use of dm_gpio instead of gpiod
I would like to see them merged. Can you respin?
Michael
Michael
Balamanikandan Gunasundar (9): nand: atmel: Add DM based NAND driver nand: atmel: Add pmecc driver mfd: syscon: Add atmel-matrix registers definition memory: atmel-ebi: add Atmel EBI (External Bus Interface) driver mfd: syscon: atmel-smc: Add driver for atmel SMC configs: at91: sam9x60ek: Enable DM based nand driver ARM: dts: at91: sam9x60: Add nodes for EBI and NAND ARM: dts: at91: sam9x60ek: Enable NAND support board: sam9x60ek: remove nand init from board file
MAINTAINERS | 1 + arch/arm/dts/sam9x60.dtsi | 42 + arch/arm/dts/sam9x60ek.dts | 103 + board/atmel/sam9x60ek/sam9x60ek.c | 59 - configs/sam9x60ek_mmc_defconfig | 9 +- configs/sam9x60ek_nandflash_defconfig | 9 +- configs/sam9x60ek_qspiflash_defconfig | 8 +- drivers/Kconfig | 2 + drivers/Makefile | 1 + drivers/memory/Kconfig | 7 + drivers/memory/Makefile | 1 + drivers/memory/atmel_ebi.c | 37 + drivers/mfd/Kconfig | 4 + drivers/mfd/Makefile | 1 + drivers/mfd/atmel-smc.c | 364 +++ drivers/mtd/nand/raw/Kconfig | 8 + drivers/mtd/nand/raw/Makefile | 1 + drivers/mtd/nand/raw/atmel/Makefile | 5 + drivers/mtd/nand/raw/atmel/nand-controller.c | 2300 ++++++++++++++++++ drivers/mtd/nand/raw/atmel/pmecc.c | 969 ++++++++ drivers/mtd/nand/raw/atmel/pmecc.h | 94 + include/linux/mfd/syscon/atmel-matrix.h | 112 + include/linux/mfd/syscon/atmel-smc.h | 119 + 23 files changed, 4188 insertions(+), 68 deletions(-) create mode 100644 drivers/memory/atmel_ebi.c create mode 100644 drivers/mfd/Kconfig create mode 100644 drivers/mfd/Makefile create mode 100644 drivers/mfd/atmel-smc.c create mode 100644 drivers/mtd/nand/raw/atmel/Makefile create mode 100644 drivers/mtd/nand/raw/atmel/nand-controller.c create mode 100644 drivers/mtd/nand/raw/atmel/pmecc.c create mode 100644 drivers/mtd/nand/raw/atmel/pmecc.h create mode 100644 include/linux/mfd/syscon/atmel-matrix.h create mode 100644 include/linux/mfd/syscon/atmel-smc.h
-- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 michael@amarulasolutions.com __________________________________
Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 info@amarulasolutions.com www.amarulasolutions.com