On Thursday, April 09, 2015 at 07:05:15 PM, maitysanchayan@gmail.com wrote:
Hello,
On 15-04-09 18:09:46, Marek Vasut wrote:
On Tuesday, April 07, 2015 at 09:03:45 AM, maitysanchayan@gmail.com wrote:
Hello,
On 15-04-01 21:15:21, Marek Vasut wrote:
On Wednesday, April 01, 2015 at 11:54:22 AM, Sanchayan Maity wrote:
The commit message is missing, please fix in v2.
Signed-off-by: Sanchayan Maity maitysanchayan@gmail.com
[...]
+#define USB_NC_REG_OFFSET 0x00000800 +#define USBCx_CTRL_OFFSET 0x00000000 +#define USBCx_PHY_CTRL_OFFSET 0x00000018
Please define the register offsets using the regular struct {} method, see for example struct mxs_usbphy_regs and it's usage in ehci-mxs.c .
I had a query here, just to be sure and avoid rework. The vybrid defines would be similar to mxs. I assume I can add them to the regs-common.h file along with a note that the VF610 also has the same _set, _clr, _tog register? Or perhaps it would be more appropriate to have the file have generic names which mxs, vf and imx can all leverage? Though for now this would require reworking all the three drivers.
The USB phy definitions part is ok, as they would go in the arch specific folder.
If these are really IMX/MXS/VF specific, then the defines should go into arch/arm/include/asm/imx-common/ . Otherwise, you can make chipidea specific file in include/usb/ .
Not really much VF specific. I was not sure about using the mxs_ prefix accessors for VF as well. In the end I found usage in one iMX6 file and decided that it makes better sense to actually use the mxs_ existing defines. They can be used for Vybrid as well. Except for the non core regsiters and a few others no other difference.
I send a v2 version of the patchset based taking your suggestion into account. The driver looks cleaner in comparison to the previous :) IMHO. Thanks.
https://www.mail-archive.com/u-boot@lists.denx.de/msg168727.html
Roger. If you drop the MXS prefix, feel free to do that in a separate patch, so this set can go in first :)