Scott Wood wrote:
On Tue, Oct 07, 2008 at 11:42:38AM +0200, Dirk Behme wrote:
Is it OK if config gets written before control, or if this whole thing gets done out of order with respect to other raw writes?
Hmm. I replaced this with the version from Nishanth's U-Boot v2 (see link above). If this isn't ok, can you explain a little more?
I was referring to the raw accessors, which you removed, so it's OK.
:)
I.e. with patch in attachment we don't touch nand_base.c any more, but still have an #ifdeffed user command in cmd_nand.c. If you don't like this, please give a hint how to better do this.
If at all possible, fix Linux to accept hardware ECC.
Yes, as mentioned by Nishanth, too, this will be possible. But I don't think in the short term, and not with breaking compatibility with kernels already out there. So for the moment I like to have both options, HW & SW ECC.
Otherwise, either add something to the MTD API that the nand command can call, or have your own board-specific command defined in the board file. Don't put platform-specific ifdefs in generic files.
Do you have any example how to extend MTD API and/or can link to example where board-specific command is already used?
Thanks
Dirk