On Wed, 15 May 2019 at 02:02, Chris Packham judge.packham@gmail.com wrote:
On Wed, May 15, 2019 at 9:54 AM Simon Glass sjg@chromium.org wrote:
This series updates patman to support Python 3:
- Avoid using 'unicode' type directly
- Use items() instead of iteritems()
- Make sure file I/O uses binary mode where necessary
- Change print statements to functions
- Use the built-in set() class
- Fix up generation of repeated bytes
A few patches for binman are included, but this still requires Python 2.
Couple of comments on 14/21 but the rest of the series
Reviewed-by: Chris Packham judge.packham@gmail.com
Simon Glass (21): patman: Update cros_subprocess to use bytearray patman: Convert print statements to Python 3 binman: Convert print statements to Python 3 binman: Don't show errors for failed tests binman: Remove use of Set() patman: Use items() instead of iteritems() binman: Use items() instead of iteritems() tools: binman: Open all binary files in binary mode tools: dtoc: Open all binary files in binary mode patman: Provide a way to get program output in binary mode binman: Use binary mode when compressing data binman: Drop an unused input file binman: Handle repeated bytes for Python 3 Add a simple script to remove boards patman: Support use of stringIO in Python 3 patman: Move unicode helpers to tools patman: Sort series output for repeatabily patman: Avoid unicode type in settings unit tests patman: Adjust functional tests for Python 3 patman: Tidy up a few more unicode conversions patman: Don't require Python 2
tools/binman/binman.py | 26 +++- tools/binman/bsection.py | 7 +- tools/binman/control.py | 8 +- tools/binman/elf.py | 4 +- tools/binman/elf_test.py | 2 +- tools/binman/entry.py | 5 +- tools/binman/etype/blob.py | 2 +- tools/binman/etype/fill.py | 4 +- tools/binman/etype/gbb.py | 2 +- tools/binman/etype/u_boot_spl_bss_pad.py | 2 +- tools/binman/ftest.py | 81 ++++++------ tools/binman/state.py | 7 +- tools/dtoc/fdt.py | 2 +- tools/patman/cros_subprocess.py | 53 +++++--- tools/patman/func_test.py | 41 ++++--- tools/patman/gitutil.py | 16 +-- tools/patman/patman.py | 2 +- tools/patman/series.py | 20 +-- tools/patman/settings.py | 34 ++--- tools/patman/test_util.py | 16 +-- tools/patman/tools.py | 55 ++++++++- tools/rmboard.py | 150 +++++++++++++++++++++++ 22 files changed, 385 insertions(+), 154 deletions(-) create mode 100755 tools/rmboard.py
-- 2.21.0.1020.gf2820cf01a-goog
Applied series to u-boot-dm/next
Due to a patchwork bug, some patches show up with missing spaces in the UI, e.g. here http://patchwork.ozlabs.org/bundle/sjg/dm/
So my script which emails on each patch doesn't work, sorry.
- Simon