Hi Florian,
On Sat, Oct 14, 2017 at 8:00 PM, Florian Fainelli f.fainelli@gmail.com wrote:
Add a minimalistic Broadcom BCM53xx (roboswitch) switch driver similar to the Marvell MV88E617x. This takes care of configuring the minimum amount out of the switch hardware such that each user visible port (configurable) and the CPU port can forward packets between each other while preserving isolation with other ports.
This is useful for e.g: the Lamobo R1 board featuring a Broadcom BCM53125 switch.
Signed-off-by: Florian Fainelli f.fainelli@gmail.com
One small nit below, but...
Acked-by: Joe Hershberger joe.hershberger@ni.com
drivers/net/phy/Kconfig | 14 ++ drivers/net/phy/Makefile | 1 + drivers/net/phy/b53.c | 629 +++++++++++++++++++++++++++++++++++++++++++++++ drivers/net/phy/phy.c | 3 + include/phy.h | 1 + 5 files changed, 648 insertions(+)
[ ... ]
+static int b53_probe(struct phy_device *phydev) +{
struct b53_device *dev;int ret;dev = malloc(sizeof(*dev));if (!dev)return -ENOMEM;memset(dev, 0, sizeof(*dev));phydev->priv = dev;dev->bus = phydev->bus;dev->cpu_port = CONFIG_B53_CPU_PORT;ret = b53_switch_reset(phydev);if (ret < 0)return ret;phydev->priv = dev;
Why set this twice?
return 0;+}
[ ... ]