On 30 August 2018 at 00:00, Manivannan Sadhasivam manivannan.sadhasivam@linaro.org wrote:
Hi Ezequiel,
On Wed, Aug 29, 2018 at 03:11:17AM -0300, Ezequiel Garcia wrote:
Hi Manivannan,
On 21 August 2018 at 14:09, Manivannan Sadhasivam manivannan.sadhasivam@linaro.org wrote:
This patchset adds board support for Vamrs Limited Rock960, which is one of the 96Boards Consumer Edition platform based on Rockchip RK3399 SoC.
What are the differences between this consumer edition board, and the enterprise edition (aka Ficus) Vamrs board?
I asked Vamrs about this and they said the difference is very minimal.
In that case, you should try to leverage the Linux ficus.dts:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch...
If no differences, using the ficus dts should do. If there are differences, we can create a common rock960.dtsi and then enterprise and consumer edition dts.
Perhaps the devicetree and the board support can be shared with ficus support?
I'm fine with it but you seem to have added Ficus board under evb_rk3399 which I think not the good place. Since the board manufacturer is different, I would suggest you to place it under boards/vamrs as I have done here. Also with more boards coming from Vamrs, this makes much more sense.
Please let me know your thoughts!
Well, I've reused the evb support, because there was no reason to have board-specific code. If we have now a reason, then of course having a board dir makes sense.
When possible, we should try to avoid code duplication and scattering. For instance, the instructions in the README look RK3399 generic and not board specific. We should consolidate that.