On Tue, 15 Jan 2008 00:21:34 -0700 "Liu Dave" DaveLiu@freescale.com wrote:
Kim,
Could you clean up the warning in 83xx current tree?
Thanks, Dave
mpc8360emds.c: In function 'ft_board_setup': mpc8360emds.c:327: warning: assignment makes pointer from integer without a cast mpc8360emds.c:329: warning: passing argument 2 of 'fdt_getprop' makes integer from pointer without a cast mpc8360emds.c:334: warning: passing argument 2 of 'fdt_setprop' makes integer from pointer without a cast mpc8360emds.c:341: warning: assignment makes pointer from integer without a cast mpc8360emds.c:343: warning: passing argument 2 of 'fdt_getprop' makes integer from pointer without a cast mpc8360emds.c:348: warning: passing argument 2 of 'fdt_setprop' makes integer from pointer without a cast
oh alright ;)
I'll apply a patch such as this:
diff --git a/board/freescale/mpc8360emds/mpc8360emds.c b/board/freescale/mpc8360emds/mpc8360emds.c index c1691ae..f909a33 100644 --- a/board/freescale/mpc8360emds/mpc8360emds.c +++ b/board/freescale/mpc8360emds/mpc8360emds.c @@ -316,15 +316,15 @@ void ft_board_setup(void *blob, bd_t *bd) immr->sysconf.spridr == SPR_8360E_REV21) { int nodeoffset; const char *prop; - const char *path; + int path;
nodeoffset = fdt_path_offset(blob, "/aliases"); if (nodeoffset >= 0) { #if defined(CONFIG_HAS_ETH0) /* fixup UCC 1 if using rgmii-id mode */ - path = fdt_getprop(blob, nodeoffset, "ethernet0", NULL); - if (path) { - path = fdt_path_offset(blob, path); + prop = fdt_getprop(blob, nodeoffset, "ethernet0", NULL); + if (prop) { + path = fdt_path_offset(blob, prop); prop = fdt_getprop(blob, path, "phy-connection-type", 0); if (prop && (strcmp(prop, "rgmii-id") == 0)) @@ -336,9 +336,9 @@ void ft_board_setup(void *blob, bd_t *bd) #endif #if defined(CONFIG_HAS_ETH1) /* fixup UCC 2 if using rgmii-id mode */ - path = fdt_getprop(blob, nodeoffset, "ethernet1", NULL); - if (path) { - path = fdt_path_offset(blob, path); + prop = fdt_getprop(blob, nodeoffset, "ethernet1", NULL); + if (prop) { + path = fdt_path_offset(blob, prop); prop = fdt_getprop(blob, path, "phy-connection-type", 0); if (prop && (strcmp(prop, "rgmii-id") == 0))
Kim