Re: [U-Boot] [PATCH] tools/proftool: fix use-after-free

On 10/07/2015 04:19 PM, Tom Rini wrote: ..

Were you in the Coverity talk too? :)

Hi Tom,

No, I was not following that talk, sorry.

..

                    free(line);

•                   return regex_report_error(&line->regex, err, "compile",
  

•                   err = regex_report_error(&line->regex, err, "compile",
                                              tok);
  

•                   return err;
  

I am not sure you solve the problem this way. Indeed the structure pointed to by the line pointer will still have been freed before use even this way. Who knows what the memory contains when regerror() will access &line->regex, which is contained into the freed structure?

Best regards,

V.