Torsten Koschorrek wrote:
Hello,
Stefano Babic wrote:
On 06/10/2011 07:44 AM, Torsten Koschorrek wrote: Hi Torsten,
send your answer to the ML, too. Someone else can help you ;-)
Oh, yes, right. This little 'Reply All' Button, sorry :-)
size1 = get_ram_size((volatile void *)SCB9328_SDRAM_1, SCB9328_SDRAM_1_SIZE); #if ( CONFIG_NR_DRAM_BANKS> 1 ) size2 = get_ram_size((volatile void *)SCB9328_SDRAM_2, SCB9328_SDRAM_2_SIZE); .....
and then: gd->ram_size = size1 + size2 + size3 + size4;
Yes, I thought about it. The thing is, we only have one bank on the system. So, dram_init_banksize() needs a cleanup, but that's a problem for another cleanup-patch, which will be committed in a next step.
(If it's needed I could do a minor cleanup first...)
You decide. However, the code in the patch is wrong. If you have only one bank, you could directly simplify your code, I think.
Good point.
Unfortunately I have to work on another project today and next week and I think I'm not able to solve the hanging problem.
Understood, I tried only to give you some hints where to check ;-)
... and I appreciate that very much :-) Above all, your answers showed me, that I was looking in the right direction so far.
Minor fixes (such as config.mk) for the above patch should be possible, though.
Ok, agree. Fix first the problem to make MAKEALL happy and build the board again.
OK, I just tested it again, MAKEALL is happy.
'include/configs/scb9328.h' is the only file that has to be patched with the patch already send to the ml. 'board/scb9328/config.mk' and 'board/scb9328/scb9328.c' definately need a cleanup, but compilation is ok. The cleanup of those two files 'll be done next week. And hopefully I find some time next week to work on the hangup problem, too.
What's the status of this patch? Do I need to resend a modified version without config.mk and scb9328.c? Or I could do a small cleanup as discussed in this thread. But as I said, MAKEALL is happy with the modified scb9328.h
thanks Torsten