Re: [U-Boot] [PATCH v2 9/9] AVR32: Board support for ATEVK1100

Dear Gunnar Rangoy,

In message 7d98d3ebed68dfca910943a360d0b8aaa28d9c17.1232710611.git.gunnar@rangoy.com you wrote:

This patch adds support for the ATEVK1100 evaluation kit, which contains an AT32UC3A0512ES chip.

...

...

--- /dev/null +++ b/board/atmel/atevk1100/atevk1100.c

...

• /*
• .ncs_wr_pulse = 1,
• .ncs_rd_pulse = 1,
• .nwe_pulse = 1,
• .nrd_pulse = 1,
• .nwe_cycle = 2,
• .nrd_cycle = 2,
• */

All this is dead code. Please remove.

...

+/*

• • Command line configuration.
• */

+#include <config_cmd_default.h>

+#define CONFIG_CMD_ASKENV +#define CONFIG_CMD_DHCP

+#undef CONFIG_CMD_AUTOSCRIPT

Is there a specific reason for not allowing to use shell scripts?

Best regards,

Wolfgang Denk