Hi Simon,
[...]
As part of this work, can you or someone else at Linaro please add tests for the SMBIOS code?
Also as mentioned in the previous version, we should have tests for this. Ilias suggested what needs to be added to the sandbox emulator.
I pointed out what's missing on the sandbox. Asking for the tests is fine and those will be added, but since the TPM is already working in QEMU, I strongly prefer doing it there.
I know you like sandbox and you are trying to promote using it for testing, but imho having it for the TPM is not the best of examples. You are adding code emulating a really complex device. There's *always* going to be missing functionality (not to mention bugs).
The EFI TCG tests will ask more and more from the TPM. E.g there's a call for changing the active PCRs which we haven't implemented yet in EFI. We'll have to keep adding complex features to sandbox for every patch? QEMU and it's TPM already work and have all the functionality we'll ever need. In fact this [1] came out from testing on QEMU. So since QEMU and testing is an acceptable way for testing U-Boot, I'll resend my TPM MMIO patchset and we can create the tests there.
[1] https://source.denx.de/u-boot/custodians/u-boot-efi/-/commit/346cee3ac5782fe...
Thanks /Ilias