On Tuesday 24 March 2009, Kazuaki Ichinohe wrote:
This patch adds a SATA harddisk driver for the canyonlands.
Thanks.
But your patch is linewrapped and therefor hard to read and can't be applied. And the commit message could be a little more descriptive. And please don't forget to add you Signed-off-by line next time.
As a general comment I suggest that you take a look at:
http://www.denx.de/wiki/view/U-Boot/Patches
to see how patches should be posted to the list. Best would be to use the git tools (git format-patch and git send-email) for patch submission.
I'll make a review in more depth when you send a patch that's not linewrapped.
Thanks again.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================