Re: [U-Boot] [PATCH v1 2/2] tpm: Add i2c TPM driver

On Wednesday 14 December 2011 03:48:24 Che-Liang Chiou wrote:

--- /dev/null +++ b/drivers/tpm/tpm.c

+int tis_sendrecv(const uint8_t *sendbuf, size_t send_size, uint8_t *recvbuf, + size_t *recv_len) +{

• error("%s: invalid send_size %zx\n", __func__, send_size);
  

using __func__ with error() makes no sense as error() already includes that

--- /dev/null +++ b/drivers/tpm/tpm_private.h

this should probably include linux/types.h and linux/compiler.h since it uses __be32 and __packed

--- /dev/null +++ b/drivers/tpm/tpm_tis_i2c.c

• if (burstcnt > (len-1-count))
  

• 	burstcnt = len-1-count;
  

add some spaces around those "-" -mike