In message 4CD35CD1F8085945B597F80EEC8942138A24A6@exc01.bk.prodrive.nl you wrote:
--- a/cpu/arm926ejs/davinci/lowlevel_init.S +++ b/cpu/arm926ejs/davinci/lowlevel_init.S @@ -3,6 +3,11 @@
- Copyright (C) 2007 Sergey Kubushyn ksi@koi8.net
- Copyright (C) 2008 Prodrive BV pv@prodrive.nl
- Changed:
- Made board specific defines such as DDR timing and PLL
- dividers. These should be set in the board config file
*/
- Partially based on TI sources, original copyrights follow:
Please don't add changelog information to source code.
diff --git a/cpu/arm926ejs/davinci/nand.c b/cpu/arm926ejs/davinci/nand.c index 127be9f..3257f83 100644 --- a/cpu/arm926ejs/davinci/nand.c +++ b/cpu/arm926ejs/davinci/nand.c
...
- /* All EMIF initialization is done in lowlevel_init.S
* and config values are in the board config files*/
This is not the correct style for multi-line comments. The "/*" goes on a line for it's own.
diff --git a/include/configs/davinci_dvevm.h b/include/configs/davinci_dvevm.h index 8ecd059..5557723 100644 --- a/include/configs/davinci_dvevm.h +++ b/include/configs/davinci_dvevm.h @@ -52,6 +52,9 @@ #define DV_EVM #define CFG_NAND_SMALLPAGE #define CFG_USE_NOR +#define CFG_USE_INTEL_NOR /* Define this when your DVEVM has Intel
* flash instead of AMD flash*/
Ditto.
J. has commented on this before!!!
-----Original Message----- From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj@jcrosoft.com] Sent: zaterdag 22 maart 2008 14:23 To: Pieter Voorthuijsen Cc: u-boot-users@lists.sourceforge.net Subject: Re: [PATCH] DM644x: (2nd try) This patch removes all boardspecific code from the arch. part for DM644x (DaVinci) boards
And PLEASE - never top post full quote!!!!
Especially not when including patches!!!
Best regards,
Wolfgang Denk