4 Jun
2009
4 Jun
'09
1:54 p.m.
On Thu, Jun 04, 2009 at 01:47:17PM +0200, Wolfgang Denk wrote:
+static inline void clear_bit(int nr, volatile unsigned long *addr) +{
- unsigned long mask = BIT_MASK(nr);
- unsigned long *p = ((unsigned long *)addr) + BIT_WORD(nr);
- *p &= ~mask;
+}
Such code has no chance of being accepted anyway.
It tries to be generic and does not care if you use it on memory or device addresses - but for device addresses, the use of proper I/O accessor functions is mandatory.
And the functions I removed from asm-arm/bitops.h did that?