On Saturday 25 December 2021 20:48:09 Pierre Bourdon wrote:
On Sat, Dec 25, 2021 at 8:11 PM Pali Rohár pali@kernel.org wrote:
"headersz" in kwbimage_set_header() should not be affected by this patch as first argument of image_create_v1() is not modified by this patch.
I do not see here logical error. Any idea?
My bad. I moved the code you added in 2b0980c24027 above the checksum computation, but left "*imagesz = headersz;" at the end of the function where it was before. So of course this was broken, but it was my fault :-)
Perfect, problem solved. Anyway, I would be really interested in your kwb cfg file as it is probably image layout which reveal this issue.
I'll send you the fix patch shortly, tested on my Prestera/Armada XP board.
Best,
-- Pierre Bourdon delroth@gmail.com Software Engineer @ Zürich, Switzerland https://delroth.net/