On Tue, Jul 20, 2021 at 9:10 PM Patrick Delaunay patrick.delaunay@foss.st.com wrote:
Since the commit commit 6a895d039ba7 ("net: Update eQos driver and FEC driver to use eth phy interfaces") the field phyaddr of driver private data struct eqos_priv is no more used in eqos_start() for the phy_connect() parameter.
Now this variable is only initialized in eqos_probe_resources_stm32() it can be removed.
Reviewed-by: Ramon Fried rfried.dev@gmail.com Signed-off-by: Patrick Delaunay patrick.delaunay@foss.st.com
(no changes since v2)
Changes in v2:
- remove unused element in the struct eqos_priv (NEW)
drivers/net/dwc_eth_qos.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c index f048e9d585..a57c35785f 100644 --- a/drivers/net/dwc_eth_qos.c +++ b/drivers/net/dwc_eth_qos.c @@ -307,7 +307,6 @@ struct eqos_priv { struct clk clk_slave_bus; struct mii_dev *mii; struct phy_device *phy;
int phyaddr; u32 max_speed; void *descs; int tx_desc_idx, rx_desc_idx;@@ -1813,7 +1812,6 @@ static int eqos_probe_resources_stm32(struct udevice *dev) if (ret) pr_warn("No phy clock provided %d", ret);
eqos->phyaddr = -1; ret = dev_read_phandle_with_args(dev, "phy-handle", NULL, 0, 0, &phandle_args); if (!ret) {@@ -1826,9 +1824,6 @@ static int eqos_probe_resources_stm32(struct udevice *dev) if (ret) pr_warn("gpio_request_by_name(phy reset) not provided %d", ret);
eqos->phyaddr = ofnode_read_u32_default(phandle_args.node,"reg", -1); } debug("%s: OK\n", __func__);-- 2.25.1
Applied to u-boot-net/network-master Thanks, Ramon.