Dear "David Wu",
In message op.va4lblrdqigx4y@cyprus.local you wrote:
We will not accept such a mess of scriting in the top level Makefile.
It was/is a mess already. I just followed the exact top level Makefile.
Yes, there is a lot of such mess already around, but we have learned our lessen and will not add any more of it.
If it is not acceptable then I'd like to know if it is OK to -- make one separate header file in include/configs for each board -- and one config.mk per board -- or other methods -- advise please
Use "@$(MKCONFIG) -t" like other boards do.
Also, I don't understand why adding DIMM module support would result in a new config.mk file and a new linker script being added?
TEXT_BASE is changed due to changes in the memory map for different DIMM modules with different size of SDRAM and FLASH.
This is no reason to add another file - just adjust the parameters as needed.
The additions to the board config file are an unacceptable mess, too.
You mean you cannot understand the ifdefs so you think it is a mess? But I
Indeed. And I guess everybody else who is trying to figure out what the result for a specific configuration would be will have the same problems.
feel it is so neat and it supports many different configurations for uCdimm 5272 modules. I also can create many of these files with a few lines differences by each. How about this?
NAK. Please factor out common parts, eventually even into a separate header file like some boards / board families / vendors do. Then reduce the remaining #ifdef'fery to the needed minimum.
Best regards,
Wolfgang Denk