Re: [U-Boot] [PATCH] uli526x: drop newlines from device name

Hi Mike, On 6/9/2010 7:14 PM, Mike Frysinger wrote:

Device names should not contain non-printable characters like newlines.

Signed-off-by: Mike Frysingervapier@gentoo.org

drivers/net/uli526x.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/uli526x.c b/drivers/net/uli526x.c index 9477851..56eee7b 100644 --- a/drivers/net/uli526x.c +++ b/drivers/net/uli526x.c @@ -225,7 +225,7 @@ int uli526x_initialize(bd_t *bis) iobase&= ~0xf;

dev = (struct eth_device *)malloc(sizeof *dev);

• sprintf(dev->name, "uli526x#%d\n", card_number);
  

• sprintf(dev->name, "uli526x#%d", card_number);
  

  db = (struct uli526x_board_info *) malloc(sizeof(struct uli526x_board_info));

Applied to net/next.

regards, Ben