
26 Jan
2020
26 Jan
'20
7:20 p.m.
On 1/26/20 11:34 AM, Lukas Auer wrote:
Hi Sean, Usually, ret is used as a variable name here. I think it would actually make the code a bit nicer to read here, because the clock rate is not read from variable err.
Hm, I chose err instead of ret since that variable is never the return value of the function. I can change that for v2 if you'd like.
But that's just nit-picking. The patch looks good otherwise!
Reviewed-by: Lukas Auer lukas@auer.io