On Thu, Dec 05, 2019 at 04:17:38AM +0200, Aleksandr Bulyshchenko wrote:
Hello Sam, I'd like to add my 5 cents regarding separating dtimg start|size into 3 subcommands
dtimg start index <num> <addr> [varname] dtimg start id <num> <addr> [varname] dtimg start rev <num> <addr> [varname]
While I don't see real usecases for combining index with id or rev (if someone applies metainformation to dtb entries for meaningful lookup, identical entries most probably mean copy-paste error), but at the same time I see space for at least two-factor identification (e.g. model and revision). Thus API should allow (but not require) combining id and rev. The same remains relevant for abootimg as well.
[shameless plug] Agreed with Aleksandr. Users will want to provide <id> and <rev> (and possibly cust[0-4] in future) in one go/command launch.