On Monday 10 October 2011 14:59:17 Stephen Warren wrote:
I'm getting a lot of the following when running checkpatch:
WARNING: space prohibited between function name and open parenthesis '('
Should I ignore these?
So far, I've written completely new code such that it doesn't trigger this warning, but where editing existing code (e.g. just changing the name of a function), I've avoided fixing this checkpatch warning so it's more obvious what my diff is doing; equally, fixing this would cause the lines I edit to be inconsistent with those around them.
Any guidance appreciated. Thanks.
you'll probably hit a bit of this for a while as there is a lot of existing/old code in u-boot which doesn't follow checkpatch :(
hopefully that'll become less frequent over time -mike