On Thu, 30 Sep 2010 14:09:11 -0500 Peter Tyser ptyser@xes-inc.com wrote:
On Thu, 2010-09-30 at 13:40 -0500, Kim Phillips wrote:
commit 6aa3d3bfaa986f1aff5e21a9b9f68d087715b1a9 "83xx: Remove warmboot parameter from PCI init functions" missed one mpc83xx_pcie_init callsite, causing this build error:
Configuring for MPC837XEMDS_HOST board... pci.c: In function 'pci_init_board': pci.c:141: error: too many arguments to function 'mpc83xx_pcie_init'
this patch extends the commit to include that callsite.
Thanks for catching that. Should the MPC837XEMDS MAKEALL target be changed to MPC837XEMDS_HOST to include coverage of its PCI code? I
either that or the makeall code that uses boards.cfg could be extended to do certain board build variants...needs looking into.
tried running ./MAKEALL 83xx prior to submitting the offending change, but didn't catch this issue. Same for the MPC832XEMDS?
the 832x mds looks ok to me.
Kim