Re: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

Dear Lukasz Dalek,

PXA25x gadget implements common function usb_disconnect(). This patch adds this function prototype into usb.h for boards using it.

[...]

+/*

• • This isn't host
• */

The comment doesn't need to be multiline. It'd be cool if it was meaningful ... like "pxa25x can only do gadget mode, thus the following ... etc". Otherwise, we're basically there.

Can you repost the whole patchset please?

+#elif defined(CONFIG_USB_GADGET_PXA2XX)

+extern void udc_disconnect(void);

#else #error USB Lowlevel not defined #endif

Best regards, Marek Vasut