Ben,
The prototypes have place in include/asm-m68k/fsl_mcdmafec.h.
Regards, TsiChung
-----Original Message----- From: Ben Warren [mailto:biggerbadderben@gmail.com] Sent: Wednesday, January 16, 2008 8:33 PM To: Liew Tsi Chung Cc: U-Boot-Users; Wolfgang Denx; Rigby John Subject: Re: [U-Boot-Users] resend#3 [PATCH 6/8] ColdFire: Add MCF547x_8x FEC driver
Hi Tsi-Chung,
Tsi-Chung Liew wrote: <snip>
+static int fec_send(struct eth_device *dev, volatile void *packet, +int length); static int fec_recv(struct eth_device *dev); static int +fec_init(struct eth_device *dev, bd_t * bd); static void +fec_halt(struct eth_device *dev);
You don't need these prototypes.
+extern int fecpin_setclear(struct eth_device *dev, int setclear);
+#ifdef CFG_DISCOVER_PHY +extern void mii_init(void); +extern uint mii_send(uint mii_cmd); +extern int mii_discover_phy(struct eth_device *dev); extern int +mcffec_miiphy_read(char *devname, unsigned char addr,
unsigned char reg, unsigned short *value);
extern int
+mcffec_miiphy_write(char *devname, unsigned char addr,
unsigned char reg, unsigned short value);
#endif
There's no need to #ifdef prototypes, and the extern'ed ones are in header files that you've included (or should be).
Since this patch relies on others in the series, it doesn' t make sense for me to apply it.
John, if the code compiles fine with these removed, please add this to the patch and apply:
Signed-off-by: Ben Warren biggerbadderben@gmail.com
Thanks very much for your contribution, Tsi-Chung.
regards, Ben