On Fri, 16 Feb 2007 12:23:06 +0100 Wolfgang Denk wd@denx.de wrote:
In message 528646bc0702151722xc107d6fq4a388265002c5bd2@mail.gmail.com you wrote:
Are you the maintainer of the sbc8349 baord?
Did you discuss such a change with the maintainer?
Ummm... Isn't that what this mailing list is for? To discuss changes?
Yes, but there is different types of changes.
There is no need to discuss a bug fix - it should always be applied to all affected boards, of course.
But this is not a bug fix - it is a change of the board configura- tion, i. e. of the board customization. I think it is NOT a good idea if anybody meddles with the configuration of someone elses board without discussing this explicitely with the respective board maintainer. In the current case, it was totally unclear to me if "foreign" boards would be changed, or not.
I tried communicating with Paul Gortmaker without success, so I removed the sbc8349 board config from the patch. The mpc83xx branch on:
http://opensource.freescale.com/pub/scm/u-boot-83xx.git
contains the revised patch:
From 72774fb83c44f72bde3db02739973acbb5f5a096 Mon Sep 17 00:00:00 2001
From: Kim Phillips kim.phillips@freescale.com Date: Sat, 3 Feb 2007 14:30:19 -0600 Subject: [PATCH] mpc83xxEMDS: add command line editing by default
--- include/configs/MPC832XEMDS.h | 1 + include/configs/MPC8349EMDS.h | 1 + include/configs/MPC8360EMDS.h | 1 + 3 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/configs/MPC832XEMDS.h b/include/configs/MPC832XEMDS.h index b8bf00f..bcd11dc 100644 --- a/include/configs/MPC832XEMDS.h +++ b/include/configs/MPC832XEMDS.h @@ -307,6 +307,7 @@ #define CFG_BAUDRATE_TABLE \ #define CFG_NS16550_COM1 (CFG_IMMR+0x4500) #define CFG_NS16550_COM2 (CFG_IMMR+0x4600)
+#define CONFIG_CMDLINE_EDITING /* Command-line editing */ /* Use the HUSH parser */ #define CFG_HUSH_PARSER #ifdef CFG_HUSH_PARSER diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h index 861de72..ab4fe05 100644 --- a/include/configs/MPC8349EMDS.h +++ b/include/configs/MPC8349EMDS.h @@ -342,6 +342,7 @@ #define CFG_BAUDRATE_TABLE \ #define CFG_NS16550_COM1 (CFG_IMMR+0x4500) #define CFG_NS16550_COM2 (CFG_IMMR+0x4600)
+#define CONFIG_CMDLINE_EDITING /* Command-line editing */ /* Use the HUSH parser */ #define CFG_HUSH_PARSER #ifdef CFG_HUSH_PARSER diff --git a/include/configs/MPC8360EMDS.h b/include/configs/MPC8360EMDS.h index 3ad00c1..e81439a 100644 --- a/include/configs/MPC8360EMDS.h +++ b/include/configs/MPC8360EMDS.h @@ -334,6 +334,7 @@ #define CFG_BAUDRATE_TABLE \ #define CFG_NS16550_COM1 (CFG_IMMR+0x4500) #define CFG_NS16550_COM2 (CFG_IMMR+0x4600)
+#define CONFIG_CMDLINE_EDITING /* Command-line editing */ /* Use the HUSH parser */ #define CFG_HUSH_PARSER #ifdef CFG_HUSH_PARSER