Re: [PATCH v2 01/10] watchdog: wdt-uclass.c: use wdt_start() in wdt_expire_now()

On Thu, 27 May 2021 at 16:00, Rasmus Villemoes rasmus.villemoes@prevas.dk wrote:

wdt_start() does the "no ->start? return -ENOSYS" check, don't open-code that in wdt_expire_now().

Also, wdt_start() maintains some global (and later some per-device) state, which would get out of sync with this direct method call - not that it matters much here since the board is supposed to reset very soon.

Signed-off-by: Rasmus Villemoes rasmus.villemoes@prevas.dk

drivers/watchdog/wdt-uclass.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org