Hi Tom,
I think, Dirk had missed this message. Sorry for a late reply.
Inlining the func is basically OK. But could you please make a little change at the inlined code (see below)?
Beside this:
Acked-by: Reinhard Pfau reinhard.pfau@gdsys.cc
Greetings, Reinhard.
On 2016-01-14 00:12, Tom Rini wrote: [...]
diff --git a/board/gdsys/405ep/dlvision-10g.c b/board/gdsys/405ep/dlvision-10g.c index 54c7eb3..def4f9c 100644 --- a/board/gdsys/405ep/dlvision-10g.c +++ b/board/gdsys/405ep/dlvision-10g.c @@ -109,7 +109,10 @@ static void print_fpga_info(unsigned dev) && !((hardware_version == HWVER_101) && (fpga_state == FPGA_STATE_DONE_FAILED))) { puts("not available\n");
print_fpga_state(dev);
if (gd->arch.fpga_state[dev] & FPGA_STATE_DONE_FAILED)puts(" Waiting for FPGA-DONE timed out.\n");if (gd->arch.fpga_state[dev] & FPGA_STATE_REFLECTION_FAILED)puts(" FPGA reflection test failed.\n");
At this point the FPGA state is already available in the local var "fpga_state". So please replace "gd->arch.fpga_state[dev]" with just "fpga_state".
return;}
[...]