Re: [U-Boot] [PATCH 1/5] pmic: pmic_mc34vr500: Add a driver for the mc34vr500 pmic

Hi,

On 9 December 2016 at 03:08, Zhiqiang Hou Zhiqiang.Hou@nxp.com wrote:

From: Hou Zhiqiang Zhiqiang.Hou@nxp.com

This patch adds a simple pmic driver for the mc34vr500 pmic which is used in conjunction with the fsl T1 and LS1 series SoC.

Signed-off-by: Hou Zhiqiang Zhiqiang.Hou@nxp.com

drivers/power/pmic/Kconfig | 7 ++ drivers/power/pmic/Makefile | 1 + drivers/power/pmic/pmic_mc34vr500.c | 32 +++++++ include/power/mc34vr500_pmic.h | 166 ++++++++++++++++++++++++++++++++++++ 4 files changed, 206 insertions(+) create mode 100644 drivers/power/pmic/pmic_mc34vr500.c create mode 100644 include/power/mc34vr500_pmic.h

diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig index ce204b3..73e1d53 100644 --- a/drivers/power/pmic/Kconfig +++ b/drivers/power/pmic/Kconfig @@ -157,3 +157,10 @@ config PMIC_LP873X ---help--- The LP873X is a PMIC containing couple of LDOs and couple of SMPS. This driver binds the pmic children.

+config POWER_MC34VR500

•   bool "Enable driver for Freescale MC34VR500 PMIC"
  

•   ---help---
  

•   The MC34VR500 is used in conjunction with the FSL T1 and LS1 series
  

•   SoC. It provides 4 buck DC-DC convertors and 5 LDOs, and it is accessed
  

•   via an I2C interface.
  

diff --git a/drivers/power/pmic/Makefile b/drivers/power/pmic/Makefile index cd1c694..58d0241 100644 --- a/drivers/power/pmic/Makefile +++ b/drivers/power/pmic/Makefile @@ -32,3 +32,4 @@ obj-$(CONFIG_POWER_TPS65218) += pmic_tps62362.o obj-$(CONFIG_POWER_TPS65218) += pmic_tps65218.o obj-$(CONFIG_POWER_TPS65910) += pmic_tps65910.o obj-$(CONFIG_POWER_HI6553) += pmic_hi6553.o +obj-$(CONFIG_POWER_MC34VR500) += pmic_mc34vr500.o diff --git a/drivers/power/pmic/pmic_mc34vr500.c b/drivers/power/pmic/pmic_mc34vr500.c new file mode 100644 index 0000000..db9e210 --- /dev/null +++ b/drivers/power/pmic/pmic_mc34vr500.c @@ -0,0 +1,32 @@ +/*

• • Copyright 2016 Freescale Semiconductor, Inc.
• • Hou Zhiqiang Zhiqiang.Hou@freescale.com
• • SPDX-License-Identifier: GPL-2.0+
• */

+#include <common.h> +#include <errno.h> +#include <i2c.h> +#include <power/pmic.h> +#include <power/mc34vr500_pmic.h>

+int power_mc34vr500_init(unsigned char bus) +{

•   static const char name[] = "MC34VR500";
  

•   struct pmic *p = pmic_alloc();
  

We have a driver-model PMIC framework now so can you please convert this to use that? We should move towards removing the old framework.

Regards, Simon