Re: [U-Boot] [PATCH v2 06/11] cfb_console: Add support for some ANSI terminal escape codes

Dear Pali =?ISO-8859-1?Q?Roh=E1r?=,

In message 3284404.3VX1zBQJtc@pali you wrote:

...

...

• if (ansi_buf_size > 0) {

• /*
  

• 0 - ESC
  

• 1 - [
  

• 2 - num1
  

• 3 - ..
  

• 4 - ;
  

• 5 - num2
  

• 6 - ..
  

• 7 - cchar
  

wrong comment ... did you even run these patches through checkpatch? Run them and resubmit please, I'm ending my review here.

Yes, I all patches except first is OK for checkpatch. It show no errors and no warnings.

Nevertheless, this violates the CodingStyle (see entry for multiline comments); please fix globally.

Best regards,

Wolfgang Denk