Dear Timur Tabi,
In message ed82fe3e0908220440u26990f80x9db39de082996868@mail.gmail.com you wrote:
This patch causes compiler warnings:
Configuring for MVBC_P board... e1000.c: In function 'e1000_transmit': e1000.c:5019: warning: passing argument 1 of 'virt_to_phys' discards qualifiers from pointer target type
That's odd. I had those warnings at one point on my system and fixed them before I submitted the patch.
Can you please look into this?
- DEBUGOUT();
- DEBUGFUNC();
...
These changes are unrelated to the change and not even mentioned in the commit message.
I do mention them:
"Also fix some bad usage of the DEBUGOUT macro"
Ah, indeed.
Unless you're talking about the summary. I figured the changes were harmless and just added them as a freebie. It's not worth submitting a different patch for just these.
Well, it is a code change, and an unrelated one. As such, it belongs into a separate commit.
Best regards,
Wolfgang Denk