Dear Tom,
In message 20180220220328.GC4311@bill-the-cat you wrote:
We need to make sure that the MMC sub-system is ready in even a non-MMC boot case.
Therefore, initialize mmc before loading environment from it.
Signed-off-by: Faiz Abbas faiz_abbas@ti.com
Applied to u-boot/master, thanks!
I had sent a (gentle) NAK for this patch before (Message-id: 20180207085212.387EB2406CC@gemini.denx.de Date: Wed, 07 Feb 2018 09:52:12 +0100).
It is wrong to initialize any sub-system just in case it might be needed. Quote from my message:
In this case I hereby NAK this patch.
U-Boot shall always use lazy initialization and never ever initialize hardware which it does not really use - see especially item 2 at [1].
[1] http://www.denx.de/wiki/U-Boot/DesignPrinciples
Why do you ignore this NAK, and why do you add this patch so late in the release cycle anyway?
Best regards,
Wolfgang Denk