Dear Wolfgang Denk,
Dear Marek Vasut,
In message 1337729574-30475-1-git-send-email-marex@denx.de you wrote:
These targets allow for easy invocation of mxstool, for generating the u-boot images bootable in mx28 CPU.
Thanks.
+$(obj)u-boot.mx28.sd: $(obj)u-boot.sb
$(obj)tools/mxsboot sd $(obj)u-boot.sb $(obj)u-boot.mx28.sd+$(obj)u-boot.mx28.nand: $(obj)u-boot.sb
$(obj)tools/mxsboot nand $(obj)u-boot.sb $(obj)u-boot.mx28.nandThere are rules missing to clean up these new images when make clean / make distclean is used.
Why do we need this special "mx28" part in the name? I don't see how this would be useful, but it hurts as you will have to add a (probably growing) list uf targets to the remove lists. - what's wrong with just calling these "u-boot.bin.sd" and "u-boot.bin.nand" ?
Because there'd then be no way to tell apart u-boot.bin.sd for another target but mx28.
Maybe add some switch statement based on CONFIG_MX28 or another within the target?
Would it not be useful to automatically build these images when someone runs just "make -j8 -s m28evk" (or "./MAKEALL m28evk") ?
Usually, you just want to update the system. You don't need the full image for that in NAND case. You do in SD card. Ok, it might be useful.
Also, I'm a bit surprised about the restrictive permissions of the resulting images:
-rw------- 1 wd wd 464320 May 23 11:09 u-boot.mx28.sd -> umask 0002
This should be fixed (probably in tools/mxsboot0 ?
That's a separate bug, but ok.
Best regards,
Wolfgang Denk
Best regards, Marek Vasut
Best regards, Marek Vasut