Am Donnerstag, den 12.01.2012, 11:53 +0100 schrieb Michal Simek:
Wolfgang Denk wrote:
Dear Stephan Linz,
But what would be the best implementation for unspecified targets here?
The question is actually a very simple one here: is there any board configuration in mainline that will actually compile and link against this driver? If yes, then everything is fine. If not, we would not even know if there were gross syntax errors in that code, and we would never notce when changes to other parts break compatibility with it.
This is why I will not add any code that is not used in mainline - out-of-tree users don't help a bit.
OK. Stephan, please send v8 with suggested changes with all patches or link to patches which are necessary to use. Please also define fake address XILINX_LLTEMAC_BASEADDR in xparameters.h to be compiled. The same we will do for axi emac driver.
Stephan if you like I can add that changes to my custodian git tree and do final testing before we ask Wolfgang to merge.
I can release the v8 patch next week. I will do some tests on weekend before I post the results here on list. The next release will be prepared to support more than one TEMAC cores (LL_TEMAC0 nad LL_TEMAC1). So I need a little bit more time to test ....