Re: [U-Boot] [PATCH v2] net: Check network device driver name

Mike Frysinger wrote:

On Tuesday, August 30, 2011 05:30:13 Michal Simek wrote:

...

--- a/net/eth.c +++ b/net/eth.c @@ -224,6 +224,14 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name, int eth_register(struct eth_device *dev) { struct eth_device *d;

• size_t len = strlen(dev->name);
• if (len >= NAMESIZE) {

• printf("Network driver name is too long (%zu >= %zu): %s\n",
  

• 				len, NAMESIZE, dev->name);
  

• return -1;
  

• }

thinking a little more, i wonder if this wouldnt be better as an assert() or BUG_ON(). this isnt a normal issue and generally gets caught once -- during development of a new board.

Just during development. Not sure if possible to do configuration run-time through custom command. If yes then it can be useful too.

Michal