Hi Minkyu
On 06/02/2010 12:18, Minkyu Kang wrote:
Dear kevin.morfitt
2009/12/29 kevin.morfitt@fearnside-systems.co.uk kevin.morfitt@fearnside-systems.co.uk:
Changes the names of the s3c24x0 register struct members from upper-case to lower-case.
Signed-off-by: Kevin Morfittkevin.morfitt@fearnside-systems.co.uk
checkpatch.pl reports no errors. MAKEALL ARM9 reports no new warnings or errors.
Note that this is based on the u-boot-master repository. The versions of s3c24x0_nand.c file are different in the u-boot-samsung, u-boot-nand-flash and u-boot-master repositories.
board/mpl/vcma9/vcma9.c | 42 ++-- board/mpl/vcma9/vcma9.h | 20 +- board/samsung/smdk2400/smdk2400.c | 29 +- board/samsung/smdk2410/smdk2410.c | 38 ++- board/sbc2410x/sbc2410x.c | 46 ++-- board/trab/auto_update.c | 1 + board/trab/cmd_trab.c | 36 ++- board/trab/rs485.c | 44 ++- board/trab/trab.c | 71 ++-- board/trab/trab_fkt.c | 159 +++++---- board/trab/tsc2000.c | 38 +- board/trab/tsc2000.h | 112 ++++--- board/trab/vfd.c | 89 +++--- cpu/arm920t/s3c24x0/interrupts.c | 3 +- cpu/arm920t/s3c24x0/speed.c | 8 +- cpu/arm920t/s3c24x0/timer.c | 18 +- cpu/arm920t/s3c24x0/usb.c | 11 +- cpu/arm920t/s3c24x0/usb_ohci.c | 15 +- drivers/i2c/s3c24x0_i2c.c | 102 +++--- drivers/mtd/nand/s3c2410_nand.c | 24 +- drivers/rtc/s3c24x0_rtc.c | 52 ++-- drivers/serial/serial_s3c24x0.c | 26 +- include/asm-arm/arch-s3c24x0/s3c24x0.h | 578 ++++++++++++++++---------------- 23 files changed, 819 insertions(+), 743 deletions(-)
Sorry for late reply.
No problem - thanks for looking at them.
I tried to review your patch series, but your patch is too confusion, because of files are scattered in every patches. If possible, could you please remake patches? Please make to one file's modification by one patch.
The patches are split so that each patch makes only one type of change, so there's only one thing that needs to be checked in each patch.
- patches 1 and 2 only make white-space changes (the change was too big so I had to split it into 2 patches) - patch 3 only makes code style changes such as moving external function prototypes to header files, removing unused code, making line lengths less than 81 characters, brackets around if/then/else/when/do blocks, generally anything that checkpatch.pl warns about - patch 4 changes the s3c24x0 register struct members to lower case (which is the main aim of the patches)
I can modify the patches to do all changes at the same time but when I've done this before I've always been told that each patch should have only one type of change in it, and I'm not sure if it would get NACK'ed by someone else.
What do you think - do you still want me to change the patch series?
Regards Kevin
Thanks to effort for your cleaning works. Minkyu Kang