On 11/24/2024 12:37 PM, Siddharth Vadapalli wrote:
Commit 5b84d2de5e6c ("board: am64x: Define capsule update firmware info") updated the "dfu_alt_info" variable to support use-cases with Serial Flash. However, this breaks use-cases where interface is not Serial Flash ("sf"). Fix this by setting "dfu_alt_info" only when the interface is "sf".
Fixes: 5b84d2de5e6c ("board: am64x: Define capsule update firmware info") Signed-off-by: Siddharth Vadapalli s-vadapalli@ti.com
v1: https://patchwork.ozlabs.org/project/uboot/patch/20241124051545.382397-2-s-v... Changes since v1:
- Replaced "SPI Flash" with "Serial Flash" everywhere.
Regards, Siddharth.
board/ti/am64x/evm.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/board/ti/am64x/evm.c b/board/ti/am64x/evm.c index 00b8317d6b..18f7770bc1 100644 --- a/board/ti/am64x/evm.c +++ b/board/ti/am64x/evm.c @@ -56,7 +56,13 @@ struct efi_capsule_update_info update_info = { #if IS_ENABLED(CONFIG_SET_DFU_ALT_INFO) void set_dfu_alt_info(char *interface, char *devstr) {
- if (IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT))
Could you evaluate possibility of moving this function along with others to
board/ti/common/ area.
Regards
Udit
- /*
* Since the EFI Capsule support is enabled only for Serial Flash,* update the "dfu_alt_info" environment variable only if the* interface happens to be "sf" (Serial Flash).*/- if (IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT) &&
(strcmp(interface, "sf") == 0))