Re: [U-Boot] [PATCH 06/33] x86: Panic if there is not relocation data

On Wed, Nov 12, 2014 at 8:17 AM, Simon Glass sjg@chromium.org wrote:

This normally indicates a problem which will prevent relocation from functioning, resulting in a hang. Panic in this case to make it easier to debug.

Signed-off-by: Simon Glass sjg@chromium.org

arch/x86/lib/relocate.c | 3 +++ 1 file changed, 3 insertions(+)

diff --git a/arch/x86/lib/relocate.c b/arch/x86/lib/relocate.c index faca38f..b33586b 100644 --- a/arch/x86/lib/relocate.c +++ b/arch/x86/lib/relocate.c @@ -76,6 +76,9 @@ int do_elf_reloc_fixups(void) /* The size of the region of u-boot that runs out of RAM. */ uintptr_t size = (uintptr_t)&__bss_end - (uintptr_t)&__text_start;

•   if (re_src == re_end)
  

•           panic("No relocation data");
  

•   do {
            /* Get the location from the relocation entry */
            offset_ptr_rom = (Elf32_Addr *)re_src->r_offset;
  

--

Reviewed-by: Bin Meng bmeng.cn@gmail.com