Re: [RFC 3/7] dtoc: update dtb_platdata to support cd-gpio

On Sun, 29 Mar 2020 at 21:32, Walter Lozano walter.lozano@collabora.com wrote:

Signed-off-by: Walter Lozano walter.lozano@collabora.com

tools/dtoc/dtb_platdata.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)

This looks OK, but please add a test.

diff --git a/tools/dtoc/dtb_platdata.py b/tools/dtoc/dtb_platdata.py index 037e82c8bb..c52da7925e 100644 --- a/tools/dtoc/dtb_platdata.py +++ b/tools/dtoc/dtb_platdata.py @@ -211,7 +211,7 @@ class DtbPlatdata(object): Return: Number of argument cells is this is a phandle, else None """

•    if prop.name in ['clocks']:
  

•    if prop.name in ['clocks', 'cd-gpios']:
         if not isinstance(prop.value, list):
             prop.value = [prop.value]
         val = prop.value
  

@@ -231,8 +231,11 @@ class DtbPlatdata(object): if not target: raise ValueError("Cannot parse '%s' in node '%s'" % (prop.name, node_name))

•            prop_name = '#clock-cells'
  

•            cells = target.props.get(prop_name)
  

•            cells = None
  

•            for prop_name in ['#clock-cells', '#gpio-cells']:
  

•                cells = target.props.get(prop_name)
  

•                if cells:
  

•                    break
             if not cells:
                 raise ValueError("Node '%s' has no '%s' property" %
                         (target.name, prop_name))
  

-- 2.20.1