David Jander wrote:
Signed-off-by: David Jander david@protonic.nl
Hi Dave,
arch/arm/cpu/armv7/mx51/iomux.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
Probably iut is better you set a more useful comment in your commit. Instead of "Added support for mxc_iomux_set_input()", you can explain which is the new feature you provide. Something to explain you add a utility for the "daisy chain" pins, to control the input path to a module when the module can be connected to more as one pin.
The patch is part of a series. However, I can see only the first two patches. Is there something missing ? I do not see any relation between these two patches, too.
+void mxc_iomux_set_input(iomux_input_select_t input, u32 config) +{
- u32 pad_reg = IOMUXSW_INPUT_CTL+(input*4);
Code styling, you should add spaces:
u32 pad_reg = IOMUXSW_INPUT_CTL + (input * 4);
- writel(config, pad_reg);
+}
Best regards, Stefano Babic