Re: [U-Boot] [PATCH v3 17/18] lcd: Add CONSOLE_SCROLL_LINES option to speed console

Hi Mike,

On Thu, Jul 19, 2012 at 7:04 AM, Mike Frysinger vapier@gentoo.org wrote:

On Thursday 12 July 2012 11:25:17 Simon Glass wrote:

...

--- a/README +++ b/README

•         CONSOLE_SCROLL_LINES
  

•         When the console need to be scrolled, this is the number of
  

•         lines to scroll by. It defaults to 1. Increasing this makes
  

•         the console jump but can help speed up operation when scrolling
  

•         is slow.
  

board knobs should be CONFIG_xxx

...

--- a/common/lcd.c +++ b/common/lcd.c

static void console_scrollup (void) {

• int rows = 1;
  

+#ifdef CONSOLE_SCROLL_LINES

• rows = CONSOLE_SCROLL_LINES;
  

+#endif

seems like this should be at the top of the file: #ifndef CONSOLE_SCROLL_LINES # define CONSOLE_SCROLL_LINES 1 #endif

Yes, both done, thanks.

-mike

Regards, Simon