21 Jul
2009
21 Jul
'09
5:11 p.m.
On Tuesday 21 July 2009 17:05:56 Wolfgang Denk wrote:
int checkboard(void) {
- printf ("Board: MPC8641HPCN, System ID: 0x%02x, "
"System Version: 0x%02x, FPGA Version: 0x%02x\n",
- u8 vboot;
- printf ("Board: MPC8641HPCN, Sys ID: 0x%02x, "
"Sys Ver: 0x%02x, FPGA Ver: 0x%02x, ",- vboot = in8(PIXIS_BASE + 0x16);
--------------------------------^^^^^^^
Maybe you can use a symbolic name here, too?
- if ((vboot >> 7) & 0x1)
if (vboot & 0x80) ???
printf ("vBank: %d\n", ((vboot >> 6) & 0x1));printf ("vBank: %d\n", !!(vboot & 0x40)); ???And eventually you can even come up with symbolic names for the magic numbers 0x80 and 0x40 ?
And please switch from using in8() to in_8().
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================