Hi Andreas,
On 08/13/2012 03:11 PM, Andreas Bießmann wrote:
+LIB := $(obj)libbootcount.o
+COBJS-y += bootcount.o +COBJS-$(CONFIG_AT91SAM9XE) += bootcount_at91.o
I tend to NAK this. Before it was available to all at91 processors (keep in mind nearly all at91 have this gpbr register). Now it is only available to AT91SAM9XE processor series which is the only user for bootcount in mainline.
Then we should choose a different CONFIG_ option here. One that selects all AT91 boards potentially supporting this feature. You are the expert here, please make a suggestion.
I fear we may break some not mainline boards here.
Maybe. But we usually don't care about out-of-tree ports.
I would prefer something that includes all different at91 SoC by default (except rm9200).
I have no solution yet but send this to prevent a v4. Will send a proposal for at91 later this day.
Okay. But I would really like to see this patch go in soon. I still have a new board support patch waiting here for quite a long time depending on this bootcount stuff.
Best regards, Stefan
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de