Hi Clément,
You're right, those its are in an old-format style. I can add a patch in this serie or send a separate patch to clean the style.
What solution do you prefer ?
Regards, Philippe
----- Mail original ----- De: "Clément Péron" peron.clem@gmail.com À: sjg@chromium.org Cc: "philippe reynes" philippe.reynes@softathome.com, "michal simek" michal.simek@xilinx.com, "joe hershberger" joe.hershberger@ni.com, "Marek Vasut" marex@denx.de, "yamada masahiro" yamada.masahiro@socionext.com, aford173@gmail.com, "woods technical" woods.technical@gmail.com, "teddy reed" teddy.reed@gmail.com, "jun nie" jun.nie@linaro.org, "peng fan" peng.fan@nxp.com, "keguang zhang" keguang.zhang@gmail.com, "andre przywara" andre.przywara@arm.com, "philipp tomsich" philipp.tomsich@theobroma-systems.com, "bin chen" bin.chen@linaro.org, jsg@jsg.id.au, nomble@palism.com, swarren@nvidia.com, "paul burton" paul.burton@mips.com, "alex kiernan" alex.kiernan@gmail.com, "u-boot" u-boot@lists.denx.de Envoyé: Samedi 3 Novembre 2018 18:11:57 Objet: Re: [PATCH V2 6/6] test: vboot: add padding pss for rsa signature
Hi,
I'm not an expert but regarding commit b8790ebeec13c882979dc986947397738d9f38aa I think you should drop the unit-address in its files.
" The DT spec demands a unit-address of a node name to match the "reg" property in that node. Newer dtc versions will throw warnings if this is not the case. Fix all occurences in the FIT image example files where this was not observed, to not give bad examples to the reader. "
Regards, Clement
On Sat, 3 Nov 2018 at 07:08, Simon Glass sjg@chromium.org wrote:
On 25 October 2018 at 03:29, Philippe Reynes philippe.reynes@softathome.com wrote:
The padding pss is now supported for rsa signature. This add test with padding pss on vboot test.
Signed-off-by: Philippe Reynes philippe.reynes@softathome.com
test/py/tests/test_vboot.py | 10 +++--- test/py/tests/vboot/sign-configs-sha1-pss.its | 46 +++++++++++++++++++++++++ test/py/tests/vboot/sign-configs-sha256-pss.its | 46 +++++++++++++++++++++++++ test/py/tests/vboot/sign-images-sha1-pss.its | 44 +++++++++++++++++++++++ test/py/tests/vboot/sign-images-sha256-pss.its | 44 +++++++++++++++++++++++ 5 files changed, 186 insertions(+), 4 deletions(-) create mode 100644 test/py/tests/vboot/sign-configs-sha1-pss.its create mode 100644 test/py/tests/vboot/sign-configs-sha256-pss.its create mode 100644 test/py/tests/vboot/sign-images-sha1-pss.its create mode 100644 test/py/tests/vboot/sign-images-sha256-pss.its
Changelog: v2:
- new patch in the serie
- add vboot for pss padding (thanks Simon Glass)
Reviewed-by: Simon Glass sjg@chromium.org