Re: [U-Boot-Users] Antw: Re: [PATCH] Add first Netstal board HCU4

Dear Niklaus,

in message ev5roc$qoo$1@sea.gmane.org you wrote:

+#define mtsdram0(reg, data) mtdcr(memcfga,reg);mtdcr(memcfgd,data)

This is bad style. Any such multi-statement macro definition should be encapsulated in a "do { ... } while (0)" frame.

•   if (bank != 0)
  

•   {
  

•           printf("\n%s: only bank 0 supported",  __FUNCTION__);
  

•           return;
  

•   }
  

Bad brace style.

Indentation not by TAB.

Please clean up!

Best regards,

Wolfgang Denk