Hi Markus,
On Friday 12 January 2007 12:07, Markus Klotzbücher wrote:
Hi Matthias,
Matthias Fuchs matthias.fuchs@esd-electronics.com writes:
Sounds reasonable to me. We still need a more pretty way to handle the +/- CFG_PCIRAM_BASE. What about some cpu_to_bus/bus_to_cpu macros?
Hmm, that sounds a bit confusing too if you're only accessing a on chip controller. How about just renaming the define to something more generic such as CFG_OHCI_RAM_OFFSET and adding a nice explanation in the README? That way it wouldn't seem so strongly related to pci.
When dealing with a pci OHCI controller the offset if pci related. But you are right, when not running on a PCI platform your name ist better.
BTW, considering Wolfgang's desire for multi ohci controller support, the constant will change into a field in the ohci struct.
Matthias