Heinrich,
On Tue, 23 Apr 2019 at 03:16, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 4/19/19 5:22 AM, AKASHI Takahiro wrote:
There are several reasons that I want to rework/refactor bootefi command as well as bootmgr:
Some previous commits on bootefi.c have made the code complicated and a bit hard to understand.
do_bootefi_exec() would better be implemented using load_image() along with start_image() to be aligned with UEFI interfaces.
Contrary to the other part, efi_selftest part of the code is unusual in terms of loading/execution path in do_bootefi().
When we will support "secure boot" in the future, EFI Boot Manager is expected to be invoked as a standalone command without any arguments to mitigate security surfaces.
In this patch set, Patch#1 to #7 are preparatory patches for patch#8. Patch#8 is a core part of reworking. Patch#9 is for standalone boot manager.
Hello Takahiro,
your patches 1-8 are now (with some modifications) in the efi-2019-07 branch. I have added some more patches.
https://github.com/xypron2/u-boot/commits/efi-2019-07
Travis CI testing was ok: https://travis-ci.org/xypron2/u-boot/builds/522947698
I have tested on real hardware without error:
- TinkerBoard (32 bit) boot via GRUB
- Pine64 A64 LTS (64 bit) boot via iPXE and GRUB
- Odroid C2 (64 bit) boot via GRUB
If you are ok with the adjustments to your patch series I will create a pull request.
Thank you for the merge. One question: how did you fix a grub error that you reported before?
-Takahiro Akashi
Best regards
Heinrich